validations are run twice
Reported by Gaspard Bucher | September 26th, 2008 @ 11:46 PM | in 1.0
once with "valid_redaction" and a second time during "save_version". See line 471..473 of multiversion.rb
We need to mimic node save as close as possible but we should avoid this double check.
An easy way to do this is by skipping validations during the second pass.
"save_version(false)" could do it.
Comments and changes to this ticket
-
Gaspard Bucher September 27th, 2008 @ 12:20 AM
- State changed from “new” to “resolved”
(from [e186e31c16344421996460492be785a1400d478e]) Fixes the double validation bug. [#218 state:resolved] http://github.com/zena/zena/comm...
-
Gaspard Bucher September 27th, 2008 @ 12:23 AM
This change gained: 5 seconds on all 6 minute tests, thats 1.3% gain. We better find better optimizations but removing silly things helps understand what is happening (the double validation was causing problems int the "before_validation" hooks).
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Anyone knows how to use formatting here ?
Git repository: http://github.com/zena
Official website: http://zenadmin.org
People watching this ticket
Gaspard Bucher
Referenced by
-
218
validations are run twice
(from [e186e31c16344421996460492be785a1400d478e]) Fixes t...