Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

validations are run twice

#218

once with "valid_redaction" and a second time during "save_version". See line 471..473 of multiversion.rb

We need to mimic node save as close as possible but we should avoid this double check.

An easy way to do this is by skipping validations during the second pass.

"save_version(false)" could do it.

Reported by Gaspard Bucher · September 26th, 2008 @ 11:46 PM

State: resolved
Milestone: 1.0
Assigned to: Gaspard Bucher Gaspard Bucher

Activity

  1. Gaspard Bucher
    Gaspard Bucher
    • State changed from new to resolved

    (from [e186e31c16344421996460492be785a1400d478e]) Fixes the double validation bug. [#218 validations are run twice state:resolved] http://github.com/zena/zena/comm...

    September 27th, 2008 @ 12:20 AM

  2. Gaspard Bucher
    Gaspard Bucher

    This change gained: 5 seconds on all 6 minute tests, thats 1.3% gain. We better find better optimizations but removing silly things helps understand what is happening (the double validation was causing problems int the "before_validation" hooks).

    September 27th, 2008 @ 12:23 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.